What’s the overhead of getting a resource resolver instance? | Community
Skip to main content
P
prestonModOp
Level 3
December 7, 2020
Solved

What’s the overhead of getting a resource resolver instance?

  • December 7, 2020
  • 6 replies
  • 3723 views

I inherited code for an application that uses resourceResolver instances quite liberally. Notably this code has a custom tag library for generating anchor tags. When called it takes the link and checks to see if it’s a page in the AEM using a resourceResolver. In the case of the navigation or footer it does this hundreds of times in total, per server hit.

 

We’re struggling with performance issues and I set JProfiler against the application and that’s the only thing that jumps out. Moderately high average CPU time making the getResourceResolver call. 

So I’m wondering what the overall overhead of this method is in case what’s happening is slowdown caused by so many calls to this method. 

This post is no longer active and is closed to new replies. Need help? Start a new post to ask your question.
Best answer by shelly-goel

@prestonmodop  In the use case like this where you need to check each url and rewrite it, using sling rewriter pipeline would be better. Sling has the possibility to rewrite the output/generated markup of a page via a pipelining feature and it is activated in AEM by default (used for the AEM-builtin link checker and link rewriting features). You would have to create a new transformer-type and add it to the rewrite configuration.

Code Examples: https://helpx.adobe.com/experience-manager/using/aem63_link_rewriter.html#AddJavafilestotheMavenprojectusingEclipse

https://www.flexibledesigns.rs/creating-a-link-rewriter/

6 replies

S
shaileshb584084
Level 2
December 7, 2020

Ideally it does not creates the spike as described.

Are you closing all the resource resolver once the job is finished or not?

 

Ideally there should be a service which utilizes the resource resolver in a method and close it once the work is finished.

 

Please explain in detail if you have some different use case and how are you using the resource resolver instance.

 

Thanks

    P
    prestonModOpAuthor
    Level 3
    December 7, 2020
    Sorry for the duplicate.
    Kiran_Vedantam
    Community Advisor
    Kiran_VedantamCommunity Advisor
    Community Advisor
    December 7, 2020

    Whenever we use ResourceResolver, it’s a 100% chance that you will open a JCR session. Hence, we should call “close()” on every resolver once the job is done.


    API calls which open a JCR resource:
    SlingRepository.loginAdminstrative() , DEPRECATED!
    SlingRepository.loginService()

    API calls, which create a Sling ResourceResolver:
    ResourceResolverFactory.getAdministrativeResourceResolver(), DEPRECATED!
    ResourceResolverFactory.getResourceResolver()
    ResourceResolverFactory.getServiceResourceResolver()

     

    Also, when we have already opened a ResourceResolver, adapting it to a Session.class will just expose the internally used JCR session; it will not create a new Session for it. Therefore we do not need to close the session.

     

    Thanks,

    Kiran Vedantam.

      P
      prestonModOpAuthor
      Level 3
      December 7, 2020
      We're closing them. And we're using the getResourceResolver() method to retrieve them.
      Shubham_borole
      Community Advisor
      Shubham_boroleCommunity Advisor
      Community Advisor
      December 7, 2020

      Not sure if the desired use of the resourceresolver can be reduced, based on the required resource/property. You can use service resolvers and instantiate the resolver using try-with-resources (https://docs.oracle.com/javase/8/docs/technotes/guides/language/try-with-resources.html) With this, as long as the try bolck is done the resource resolver and associate sessions will close.

      Some links here - https://github.com/Adobe-Consulting-Services/acs-aem-samples/blob/master/core/src/main/java/com/adobe/acs/samples/authentication/impl/SampleServiceLoginResourceResolverImpl.java

      https://www.tothenew.com/blog/access-content-repository-via-getserviceresourceresolver-in-aem6sling7/

       

      Hope this helps

       

       

        P
        prestonModOpAuthor
        Level 3
        December 7, 2020
        We're closing resources correctly. What jumped out at me when I looked at our codebase in JProfiler was how long it took to even open a resourceResolver, regardless of the fact that we're closing it correctly. And we open hundreds of them per request. That's why I was curious about the overhead of even opening one.
        shelly-goel
        Adobe Employee
        shelly-goelAdobe EmployeeAccepted solution
        Adobe Employee
        December 9, 2020

        @prestonmodop  In the use case like this where you need to check each url and rewrite it, using sling rewriter pipeline would be better. Sling has the possibility to rewrite the output/generated markup of a page via a pipelining feature and it is activated in AEM by default (used for the AEM-builtin link checker and link rewriting features). You would have to create a new transformer-type and add it to the rewrite configuration.

        Code Examples: https://helpx.adobe.com/experience-manager/using/aem63_link_rewriter.html#AddJavafilestotheMavenprojectusingEclipse

        https://www.flexibledesigns.rs/creating-a-link-rewriter/

          arunpatidar
          Community Advisor
          arunpatidarCommunity Advisor
          Community Advisor
          December 9, 2020

          Hi,

          We are also using link scanning to identify internal links with specific format using subservice session via sling output rewrite pipeline. we did not see any performance issues, even though we have a header and footer with internal links.

          I would suggest using sling rewriter pipeline which allows you to restrict link scanning based on path, link extension, attribute, tags etc. This will help to improve performance. 

          Arun Patidar
            joerghoh
            Adobe Employee
            joerghohAdobe Employee
            Adobe Employee
            December 9, 2020

            Opening a ResourceResolver is normally opening a JCR session. Which comes with some overhead.

            Some time back I profiled a publish instance in load tests and found that eliminating a single filter, which opened and closed a JCR session (and doing some work in between) increased the number of requests my publish was able to handle by ~ 5%.

            So if you do that lots of times during the rendering of a page, it will negatively impact the performance of the page rendering.

             

            Jörg

              Terms & ConditionsAccessibility statement

              Loading footer...