Highlighted

Bug with PHP SDK

Avatar

Avatar

rogerwu99

Avatar

rogerwu99

rogerwu99

16-10-2011

Just wanted to point out a bug... not sure if fixed yet in the PHP SDK:

<code>

function deleteRoom($r, $list = FALSE) {

        if ($r == null)

            throw new RTCError("parameter-required");

        return $this->delete(strtolower($r), RTCAccount::ROOM_ITEMS, $list);

    }

    //

    // delete a template

    //

    function deleteTemplate($t, $list = FALSE) {

        if ($t == null)

            throw new RTCError("parameter-required");

        return delete($t, RTCAccount::TEMPLATE_ITEMS, $list);

    }

    //

    // delete an archive

    //

    function deleteArchive($a, $list = FALSE) {

        if ($a == null)

            throw new RTCError("parameter-required");

        return delete($a, RTCAccount::ARCHIVE_ITEMS, $list);

    }

</code>

The return values for deleteTemplate and deleteArchive should be return $this->delete.....

Replies

Highlighted

Avatar

Avatar

nzezelj

Avatar

nzezelj

nzezelj

16-10-2011

Nice Catch Roger,

We'll be sure to fix it for the next release. 

Thanks,

Nikola

Highlighted

Avatar

Avatar

nzezelj

Avatar

nzezelj

nzezelj

17-10-2011

Ah yes, I caught this one in July but somehow my fix didn't make its way to the release branch.  Again, good catch, I'll make sure it makes it out in the next release.

I am also attaching the latest version of our lccs.php file to this thread. 

Thanks,

Nikola