Unclosed session detected errors in log

[chetanvajre2014]

We are seeing this error in the logs. I've seen that the vendor who wrote code for us is using something like this

 ResourceResolver resourceResolver = request.getResourceResolver();
        QueryBuilder queryBuilder = resourceResolver.adaptTo(QueryBuilder.class);
        Session session = resourceResolver.adaptTo(Session.class);

Does this session need to be closed in finally as well os it's only when we try to get administrative session that we need to correctly close it?

Any links for best practices while writing servlets and using sessions would be appreciated.

[Lokesh_Shivalingaiah]

We need to close the ResourceResolver or the Session which we initiate. Refer [1], [2] in to know more in detail

[1] https://cqdump.wordpress.com/2013/07/23/cq-development-patterns-sling-resourceresolver-and-jcr-sessi...

[2] http://www.wemblog.com/2014/08/how-to-use-sessions-and-resource.html

[chetanvajre2014]

Does this apply only while getting an admin session using resolverfactory or even a regular session using resourceResolver.adaptTo(Session.class) using the request object of the servlet?

[chetanvajre2014]

Or it makes sense to use every component like this

@Activate
  protected void activate() {
    session = null;
    try {
      session = repo.loginAdministrative();
      …
    } catch (RepositoryException e) {
      // log the exception
    }
  }

  @Deactivate
  protected void deactivate() {
    if (session != null && session.isLive()) {
      session.logout();
    }
  }

[Lokesh_Shivalingaiah]

We should not be using loginAdministrative()

when you are using resourceResolver.adaptTo(Session.class)

make sure you close resourceResolver in the final block

[chetanvajre2014]

No I meant either ways, not that we are opening sessions using both methods. If I just use session using AdaptTo, does that also need to be closed using session.close()

[Feike_Visser1 · Accepted solution]

No, rule is: You create it, you close it. Does not apply for adaptTo()

[Lokesh_Shivalingaiah]

Yes.. You will have to close the session by session.logout()

[chetanvajre2014]

hey per ~~Feike Visser  if I'm using adaptTo I don't need to close it

[Lokesh_Shivalingaiah]

Either you need to do Session.logout() just to close the session and not the resource, If you are doing ResourceResolver.close() then you dont have to explicitly do session logout. 

[Lokesh_Shivalingaiah]

https://sling.apache.org/apidocs/sling6/org/apache/sling/api/resource/ResourceResolver.html#close()

[smacdonald2008]

Here is a good article on this: 

http://scottsdigitalcommunity.blogspot.ca/2014/12/querying-adobe-experience-manager-6.html

Yes - close session by invoking session.logout();