Unclosed Resource resolver - Custom workflow step | Community
Skip to main content
N
NitroHazeDev
Level 9
January 26, 2023
Solved

Unclosed Resource resolver - Custom workflow step

  • January 26, 2023
  • 3 replies
  • 3410 views

All,

I have a custom process step within the dam update asset workflow where the step needs a resource resolver instance which I get from the workflow session via adaptTo

ResourceResolver resResolver = workflowSession.adaptTo(ResourceResolver.class);
I do NOT have a closeable try block as in below since i am not opening it..
try(ResourceResolver resResolver = workflowSession.adaptTo(ResourceResolver.class))

using com.adobe.granite.workflow.WorkflowSession

I noticed the "Unclosed resolver opened here" at INFO log level and at the above line.

Since it is not something i have opened, per my understanding, i don't believe i should be closing it.

Just an FYI: This resource resolver instance is then used to make an update to the metadata, i see ACS using similar approach just that i am not using autoclosable try cause i am not opening it, wonder why we need it?


https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/util/impl/WorkflowHelperImpl.java 

https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/workflow/process/impl/CopyPropertiesProcess.java 
public final ResourceResolver getResourceResolver(com.adobe.granite.workflow.WorkflowSession workflowSession) {
return workflowSession.adaptTo(ResourceResolver.class);
}

cc @joerghoh 

This post is no longer active and is closed to new replies. Need help? Start a new post to ask your question.
Best answer by joerghoh

yes, reason i confirmed is, strangely, when i tried adding the autocloseable try and the info message for the custom class disappeared. The blogs however, unless i am missing something do not speak to workflow session . I see it implemented with autocloseable try to close the session/resolver in ACS(links above) , makes me wonder if this is an internal bug for which autocloseable try, to close the session/resolver, is a workaround.. raised a ticket.. as a bug with tagid is confirmed
on adaptTo

 


You are correct, the code instantiates a new ResourceResolver there. My blog post is actually incorrect in that area. So you need to close this RR.

 

Thanks for spotting. I will update the post.

3 replies

Anudeep_Garnepudi
Community Advisor
Anudeep_GarnepudiCommunity Advisor
Community Advisor
January 26, 2023

@nitrohazedev 

 

ResoureResolver is an interface, you can not instantiate it. There are different ways to get the implementation in  ResoureResolver, either which way it could be it is always a good practice to close it.

AG
    N
    NitroHazeDevAuthor
    Level 9
    January 26, 2023

    Hi @anudeep_garnepudi not sure what you mean but I know it is not the wrong way to get the resolver . Question becomes, should I close it ? Which I believe should be a no , since u have not opened it .hence I believe no need for an auto close able try block 

    i do not want to get the resolver via service user , when I have the workflow session. 

    closing it if I have not opened it , I fear it can just cause troubles across 

    I see acs using similar approach just that i am not using autoclosable try, cause i am not opening it, wonder why we need it?

    https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/util/impl/WorkflowHelperImpl.java 

    https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/workflow/process/impl/CopyPropertiesProcess.java 
    public final ResourceResolver getResourceResolver(com.adobe.granite.workflow.WorkflowSession workflowSession) {
    return workflowSession.adaptTo(ResourceResolver.class);
    }

      Kiran_Vedantam
      Community Advisor
      Kiran_VedantamCommunity Advisor
      Community Advisor
      January 26, 2023

      Hi @nitrohazedev 

       

      If you would obtain a resourceResolver You did not open the resolver from a request or workflow session and do not need to close it.

       

      Check if there is any other resource resolvers causing it.

       

      Thanks,

      Kiran Vedantam

        N
        NitroHazeDevAuthor
        Level 9
        January 26, 2023

        Hi @kiran_vedantam 

        i am not sure I follow . I have obtained it from workflow session via adaptTo and hence I don’t believe I should close it or use the autoclosable try block. I don’t want to close the resolver and create an issue with the resolver being closed for next steps within workflow 

        please let me know 

         

        update- I know there are OOTB ones but can’t say if they are causing it since the custom class comes up , for this unclosed resolver
        Class reference from similar acs code - they are using similar approach just that i am not using autoclosable try cause i am not opening it, wonder why we need it?


        https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/util/impl/WorkflowHelperImpl.java 

        https://github.com/Adobe-Consulting-Services/acs-aem-commons/blob/master/bundle/src/main/java/com/adobe/acs/commons/workflow/process/impl/CopyPropertiesProcess.java 
        public final ResourceResolver getResourceResolver(com.adobe.granite.workflow.WorkflowSession workflowSession) {
        return workflowSession.adaptTo(ResourceResolver.class);
        }

          Kiran_Vedantam
          Community Advisor
          Kiran_VedantamCommunity Advisor
          Community Advisor
          January 26, 2023

          You dont need to close the resourceResolver coming from workflow session, check if anything else is causing the issue.

            DEBAL_DAS
            DEBAL_DAS
            New Member
            January 27, 2023

            As per my understanding you don't need to close the resource resolver in this case.

            Please refer these links -

            https://cqdump.joerghoh.de/2018/11/12/resourceresolvers-and-sessions-you-open-it-you-close-it/

            https://cqdump.joerghoh.de/2013/07/23/cq-development-patterns-sling-resourceresolver-and-jcr-sessions/

             

            I have learnt from @Jorg_Hoh

             

            .adaptTo() is not listed as one of methods opening a ResourceResolver, thus we should not close it.

            Debal Das, Senior AEM Consultant
              N
              NitroHazeDevAuthor
              Level 9
              January 27, 2023

              Agreed and hence the confusion .. Using closeable try means we are closing it .. right @debal_das ? 


              try(ResourceResolver resResolver = workflowSession.adaptTo(ResourceResolver.class))

               

               

                joerghoh
                Adobe Employee
                joerghohAdobe EmployeeAccepted solution
                Adobe Employee
                January 27, 2023

                yes, reason i confirmed is, strangely, when i tried adding the autocloseable try and the info message for the custom class disappeared. The blogs however, unless i am missing something do not speak to workflow session . I see it implemented with autocloseable try to close the session/resolver in ACS(links above) , makes me wonder if this is an internal bug for which autocloseable try, to close the session/resolver, is a workaround.. raised a ticket.. as a bug with tagid is confirmed
                on adaptTo

                 


                You are correct, the code instantiates a new ResourceResolver there. My blog post is actually incorrect in that area. So you need to close this RR.

                 

                Thanks for spotting. I will update the post.

                  Terms & ConditionsAccessibility statement

                  Loading footer...