Best Practice for Creating a Segment

Hi Team,

Do any of you know what is the best practice in terms of creating rule-based traits that sits within the segment?  Does using a keyword methodology for online site traffic is better than url based?  Any insights would help.

Thanks