Unclosed session detected errors in log

We need to close the ResourceResolver or the Session which we initiate. Refer [1], [2] in to know more in detail

[1] https://cqdump.wordpress.com/2013/07/23/cq-development-patterns-sling-resourceresolver-and-jcr-sessions/

[2] http://www.wemblog.com/2014/08/how-to-use-sessions-and-resource.html

Does this apply only while getting an admin session using resolverfactory or even a regular session using resourceResolver.adaptTo(Session.class) using the request object of the servlet?

Or it makes sense to use every component like this

@Activate
  protected void activate() {
    session = null;
    try {
      session = repo.loginAdministrative();
      …
    } catch (RepositoryException e) {
      // log the exception
    }
  }

  @Deactivate
  protected void deactivate() {
    if (session != null && session.isLive()) {
      session.logout();
    }
  }

We should not be using loginAdministrative()

when you are using resourceResolver.adaptTo(Session.class)

make sure you close resourceResolver in the final block

No I meant either ways, not that we are opening sessions using both methods. If I just use session using AdaptTo, does that also need to be closed using session.close()

Yes.. You will have to close the session by session.logout()

hey per ~~Feike Visser  if I'm using adaptTo I don't need to close it

Either you need to do Session.logout() just to close the session and not the resource, If you are doing ResourceResolver.close() then you dont have to explicitly do session logout. 

https://sling.apache.org/apidocs/sling6/org/apache/sling/api/resource/ResourceResolver.html#close()