hey Nigel,
SharedCollection has some wonky stuff going on:
SharedCollection:onItemReceive:353
This code updates changes that were made in an object in the collection.
for (i in newItem) {
if (newItem[i]!=oldItem[i]) {
var tmpOldValue:Object = oldItem[i];
oldItem[i] = newItem[i];
itemUpdated(oldItem, i, tmpOldValue, oldItem[i]);
}
}
Problem:
for..in loops only iterate over dynamically added properties. So, if the type of newItem is, for instance, puzzlePieceVO, then none of the properties are iterated over. So we can only use SharedCollection for a collection of Objects with an idField. (Which is how SharedCollectionExample uses it.)
Solution:
In addition to the for..in loop, use describe type to get a list of the properties and accessor and iterate over them for update. This isn't great because I'd guess that describe type is pretty slow. We can cache the types if that becomes an issue.
The other, more subtle issue is in SharedCollection:getItemID:406
var testID:String = (p_item is IUID) ? IUID(p_item).uid : p_item[idField] as String;
Problem:
Since, onItemReceive only works with types of Object, (p_item is IUID) will always evaluate to False.
Solution:
Change the code to:
var itemID:String = p_item.hasOwnProperty('uid') ? p_item['uid'] : p_item[idField] as String;
If we do that, and use VOs created from the items, then we can use this (mostly) as documented.
Now it'll work with the VOs and when we fix onItemReceive, it will continue working.
I'd love to hear your feedback on my proposed changes.
-sandy
