Expand my Community achievements bar.

SOLVED

Unable to set pipeline.type while migrating from SCR to OSGi DS annotation

Avatar

Community Advisor

Dear community members,

I am migrating my codebase from using SCR annotations to DS annotations. While the previous implementation sets the 'pipeline.type' property this way and it's working:

old-way.PNG
And I just tried this way to migrate it:

new-way.PNG

 

 

 but it couldn't set the property somehow. It threw:

bilala23933647_1-1589108387869.png

 

Valuable thoughts?

Thanks in advance, Bilal.

 

Topics

Topics help categorize Community content and increase your ability to discover relevant content.

6.4
1 Accepted Solution

Avatar

Correct answer by
Community Advisor

Hi @bilal_ahmad 

You are doing it wrong.

Refer this blog https://medium.com/adobetech/aem-6-4-creating-a-scheduler-using-osgi-r6-annotations-4ad0b8c6fce7

Unlike with SCR annotations, it is very clean and simple to create OSGi configurations using R6 annotations by simply using @AttributeDefinition.

 

If you want to create your OCD in same class then you can refer below code:

 

package aem.core.service;

import org.apache.sling.rewriter.Transformer;
import org.apache.sling.rewriter.TransformerFactory;
import org.osgi.service.component.annotations.Activate;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Modified;
import org.osgi.service.metatype.annotations.AttributeDefinition;
import org.osgi.service.metatype.annotations.Designate;
import org.osgi.service.metatype.annotations.ObjectClassDefinition;


@Component(service = TransformerFactory.class, immediate = true)
@Designate(ocd = LinkTransformerFactory.Config.class)
public class LinkTransformerFactory implements TransformerFactory {

@ObjectClassDefinition(name = "LinkTransformerFactory Service", description = "LinkTransformerFactory Configuration")
public @interface Config {

@AttributeDefinition(name = "Pipeline Type", required = true)
String getPipelineType() default "gatedassettransformer";
}

@Activate
@Modified
protected void activate(final Config config) {
String pipelineType = config.getPipelineType();
}

@Override
public Transformer createTransformer() {
return null;
}
}

 

View solution in original post

7 Replies

Avatar

Correct answer by
Community Advisor

Hi @bilal_ahmad 

You are doing it wrong.

Refer this blog https://medium.com/adobetech/aem-6-4-creating-a-scheduler-using-osgi-r6-annotations-4ad0b8c6fce7

Unlike with SCR annotations, it is very clean and simple to create OSGi configurations using R6 annotations by simply using @AttributeDefinition.

 

If you want to create your OCD in same class then you can refer below code:

 

package aem.core.service;

import org.apache.sling.rewriter.Transformer;
import org.apache.sling.rewriter.TransformerFactory;
import org.osgi.service.component.annotations.Activate;
import org.osgi.service.component.annotations.Component;
import org.osgi.service.component.annotations.Modified;
import org.osgi.service.metatype.annotations.AttributeDefinition;
import org.osgi.service.metatype.annotations.Designate;
import org.osgi.service.metatype.annotations.ObjectClassDefinition;


@Component(service = TransformerFactory.class, immediate = true)
@Designate(ocd = LinkTransformerFactory.Config.class)
public class LinkTransformerFactory implements TransformerFactory {

@ObjectClassDefinition(name = "LinkTransformerFactory Service", description = "LinkTransformerFactory Configuration")
public @interface Config {

@AttributeDefinition(name = "Pipeline Type", required = true)
String getPipelineType() default "gatedassettransformer";
}

@Activate
@Modified
protected void activate(final Config config) {
String pipelineType = config.getPipelineType();
}

@Override
public Transformer createTransformer() {
return null;
}
}

 

Avatar

Community Advisor
Thank you @ArpitVarshney for the quick response! However I tried setting that value the way you shared. Still it says "Unable to get component of class 'interface org.apache.sling.rewriter.Transformer' with type 'gatedassettransformer'". And that is strange!! Any other suspicion/thoughts ? Many Thanks, BIlal.

Avatar

Community Advisor

Hi @bilal_ahmad 

 

I've tried the same code in my AEM instance and it is working fine for me. I am able to log the updated pipeline type which is correctly reflected.

However, if the shared code is somehow not working for you, please go through the blog link that I've shared.

 

Regards,

Arpit Varshney

Avatar

Community Advisor

@bilal_ahmad 

Please refer below code which has been copied from Adobe's documentation.[Link]

 

package com.adobe.community.rewriter.core;

import org.apache.sling.rewriter.Transformer;
import org.apache.sling.rewriter.TransformerFactory;
import org.osgi.service.component.annotations.Component;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* A TransformerFactory service instance for creating a Transformer to add link
* type icons into links to documents.
*
* @author dklco@apache.org
* @see com.perficient.adobe.rewriter.LinkTypeTransformer
*/
@Component(property = { "pipeline.type=linktype" }, service = { TransformerFactory.class })
public class LinkTypeTransformerFactory implements TransformerFactory {

private static final Logger log = LoggerFactory.getLogger(LinkTypeTransformerFactory.class);

/*
* (non-Javadoc)
*
* @see org.apache.sling.rewriter.TransformerFactory#createTransformer()
*/
@Override
public Transformer createTransformer() {
log.trace("createTransformer");
return new LinkTypeTransformer();
}

}

Avatar

Community Advisor
Thank you @arunpatidar, really appreciate your help. I tried this, even then i get the same error looks like I need to try this on someone else's instance or create a fresh instance and try it. Cause I don't think that it' that complicated and just refusing to set one property! Any way, thank you so much. I will keep this area updated with my findings. Thanks, Bilal.

Avatar

Community Advisor

Dear @arunpatidar and @ArpitVarshney, Thank you very much for your valuable time and attention. While I was worried about why it wasn't working, turned out that I messed up with maven-bundle-plugin version in my project pom.xml(I was using 2.5.3 and changed it to 4.1.0 but somehow it got changed back to 2.5.3). Once i fixed that, I was being able to set the property the way I was trying without any changes in my java class:

bilala23933647_0-1589343325685.png