Model's adaptable is request - bug with @Default

Avatar

Avatar

Aryan12345

Avatar

Aryan12345

Aryan12345

29-11-2018

Hello Experts!

I have a model adaptable from request. I have resource depend injections marked with @Via("resource"). There are some where i put the tag @Default(values="default text");.

Now comes the interesting part. Even when i enter the value in the dialog for that item, it does not take that value but only default value.

Now when i change the model to accept "adapt" from resource, then the real value gets picked up and when it is not available default values get picked up which is the accepted behavior.

Is this a known issue with model adaptable from request and @Default?

please let me know.

thanks all,

YAdhu

Replies

Avatar

Avatar

Arun_Patidar

MVP

Total Posts

2.9K

Likes

1.1K

Correct Reply

839

Avatar

Arun_Patidar

MVP

Total Posts

2.9K

Likes

1.1K

Correct Reply

839
Arun_Patidar
MVP

29-11-2018

Hi,

May be using request type it is not able to find and adapt property.

try below:

@Model(adaptables=SlingHttpServletRequest.class) public interface MyModel

// will return request.getResource().getValueMap().get("propertyName", String.class)

@Inject @Via("resource")

String getPropertyName();

}

Avatar

Avatar

Aryan12345

Avatar

Aryan12345

Aryan12345

29-11-2018

Hi Arun,

Not sure I understood. My question is that @Default forces itself upon the dialog value also in case the adaptable in Request and works fine if adaptable in resource.

Any clues?

Note: the behavior is consistent after testing.

thanks,

Yadhu

Avatar

Avatar

smacdonald2008

Total Posts

12.7K

Likes

1.4K

Correct Reply

2.3K

Avatar

smacdonald2008

Total Posts

12.7K

Likes

1.4K

Correct Reply

2.3K
smacdonald2008

29-11-2018

Can you show your code please.

Avatar

Avatar

smacdonald2008

Total Posts

12.7K

Likes

1.4K

Correct Reply

2.3K

Avatar

smacdonald2008

Total Posts

12.7K

Likes

1.4K

Correct Reply

2.3K
smacdonald2008

29-11-2018

This could be a bug. I have never myslef seen an issue when i use:

adaptables = Resource.class

Avatar

Avatar

Aryan12345

Avatar

Aryan12345

Aryan12345

29-11-2018

No issues with resource.class. only with request.class. thats confirmed.

Avatar

Avatar

Arun_Patidar

MVP

Total Posts

2.9K

Likes

1.1K

Correct Reply

839

Avatar

Arun_Patidar

MVP

Total Posts

2.9K

Likes

1.1K

Correct Reply

839
Arun_Patidar
MVP

30-11-2018

I think when you adapt as request, the dialog field is not consider as adaptable for request type and thats why it is taking default but If you can try something like below, not sure I am just guessing.

You can use @ValueMapValue without via

@ValueMapValueinjectionStrategy, name and viavaluemapInjects a ValueMap value. If via is not set, it will automatically take resource if the adaptable is the SlingHttpServletRequest. If name is not set the name is derived from the method/field name.

@ValueMapValue

  @Default(booleanValues = false)
  private boolean showPrice;