Your achievements

Level 1

0% to

Level 2

Tip /
Sign in

Sign in to Community

to gain points, level up, and earn exciting badges like the new
BedrockMission!

Learn More

View all

Sign in to view all badges

Cloud manager

Avatar

Avatar
Validate 1
Level 1
mauro88888
Level 1

Likes

0 likes

Total Posts

1 post

Correct Reply

0 solutions
Top badges earned
Validate 1
View profile

Avatar
Validate 1
Level 1
mauro88888
Level 1

Likes

0 likes

Total Posts

1 post

Correct Reply

0 solutions
Top badges earned
Validate 1
View profile
mauro88888
Level 1

19-02-2021

We recently start using cloud manager for our project but with the latest version has been removed the sonar properties in order to avoid build and quality scanning failures. There where any alternative to add class exclusion from code coverage ?

cloud manger aem
View Entire Topic

Avatar

Avatar
Ignite 1
Level 4
davidjgonzalezzzz
Level 4

Likes

54 likes

Total Posts

60 posts

Correct Reply

20 solutions
Top badges earned
Ignite 1
Give Back 5
Give Back 3
Give Back 10
Give Back
View profile

Avatar
Ignite 1
Level 4
davidjgonzalezzzz
Level 4

Likes

54 likes

Total Posts

60 posts

Correct Reply

20 solutions
Top badges earned
Ignite 1
Give Back 5
Give Back 3
Give Back 10
Give Back
View profile
davidjgonzalezzzz
Level 4

19-02-2021

I assume by "sonar properties" you mean setting blanket exclusions at the POM level?

 

It's typically unwise to blanket exclude entire packages/classes from code quality checks.

 

What you should  do is:

1. Review violations reported by Cloud Manager, and fix the ones you can

1. There may be reported issues that aren't for whatever reason you do not want to/cannot change, for these, it is better to explicitly suppress that exact warning for just that method/class similar to [1]. This way if you evolve that code, and introduce a violation you should correct, Cloud Manager can alert you about it - if you completely exclude packages/classes for being scanned, this is a good way to result in an unstable/vulnerable app.

 

Also, FWIW - in my experience the "estimated time to resolve" issues in the Cloud Manager violation repo is exceedingly generous. It usually takes me a maybe .. 1/10th of the estimated time to resolve most issues - so don't let that # scare you off from improving your code base.

 

[1] https://github.com/Adobe-Marketing-Cloud/asset-share-commons/blob/bc16654589301bd2990302a82c701558b5...